Adapt cost accounting for multi-year-periods #993
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rizon in invest flow
…lculation of present values
The test seems to be designed to test if warnings can be turned off. However, the operation never created one.
* pytest.approx instead of roundin * series.iloc[int] instead of series[int]
…s-parameter Remove obsolete fixed costs parameter for GenericCAES initialization
|
Seeing this, I would suggest to do the accounting in pre-processing and leave the complexity out of solph. (I know, it's already there in the multi-period feature. But this might be something to discuss at the dev meeting next month.) |
…es-of-multi-period-investments Account for remaining values in multi-period models
Fix/eliminate warnings
The time unit currently is hardcoded to be hours. The documentation now reflects that.
The constraints are actually defined in time steps. (The documentation asked for integers before, so it could be seen from the context.)
Fix/specific timeincrement docs
It is now mandatory to do so to geht the docs built.
This is now mandatory to have RTD builds.
The format seems to be different from the one below.
make BasicModel consider all constraint groups
This was referenced May 21, 2024
|
Hello @nailend! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
|
…-multi-year-periods_to_052ev1_and_fix Update branch adapt-costs-for-multi-year-periods to v0.5.2.dev1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #992
as desribed in urbs
https://urbs.readthedocs.io/en/latest/theorydoc/intertemp_prob.html?highlight=annuity#costs
get_period_duration()use_representative_yearadd base-year offset in case base_year not first representative year(e.g. 2021=first representativ year but base_year =2020)