-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Periodic value deserialization #124
Conversation
The period information is needed to create the list of periodic values. Therefore the reading has to take place beforehand.
If a list length equals the number of periods it is converted to a timeseries of total timeindex length. The value will change corresponding to the periods.
Change in oemof.solph issue 983 might have an effect on this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change requested. Otherwise this looks good to me.
@henhuy not sure what's happening here and why the tests fail. Locally, there is no error ... Could you please check locally as well? |
I could reproduce error with latest python version 3.9.18 - in 3.9.16 error did not occur.
We could implement this fix in |
Strange... python version 3.9.18 is from August'23 and was also already used in this CI run which wasn't failing. |
I found it. It's caused by changes in |
Unfortunately, network has some untested and undocumented parts. I did a release that did not really change anything to the "official" API. I already reversed the checks that @henhuy mentioned in dev branch of solph: oemof/oemof-solph@559c681. Probably, a release makes sense as well. |
There now is oemof.solph 0.5.2.dev0 that should fix the issue. |
close #115
if multi-period approach is taken (periods resource exists):
This is only possible for certain parameters, otherwise building the energy system fails.
Attention:
The investment parameters work differently. One period specific value is enough, and a whole timeseries is not necessary. Check here
e.g. "fixed_costs" "capacity_costs"
These period values are handled differently: