Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue deprecation warning for Python<3.9 #125

Merged

Conversation

fwitte
Copy link
Member

@fwitte fwitte commented Aug 25, 2023

As discussed in #101

@fwitte fwitte requested review from gnn, p-snft and nailend August 25, 2023 12:38
@fwitte
Copy link
Member Author

fwitte commented Aug 25, 2023

Is this a correct way to issue warnings? Or does it only work if someone directly imports oemof.tabular and not from oemof.tabular?

@fwitte fwitte changed the title Issue depriciation warning for Python<3.9 Issue deprecation warning for Python<3.9 Aug 25, 2023
Copy link
Collaborator

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made some comments, but your version is totally sufficient. Thanks for the proposal.

src/oemof/tabular/__init__.py Outdated Show resolved Hide resolved
src/oemof/tabular/__init__.py Outdated Show resolved Hide resolved
@fwitte
Copy link
Member Author

fwitte commented Aug 28, 2023

Thanks for the suggestions, I pushed the changes. I do not consider myself an active user/developer of oemof.tabular. Therefore I would like others to merge or not to merge this. So go ahead as you like, same for #101

@nailend nailend merged commit 7ef90d2 into dev Aug 28, 2023
@nailend nailend deleted the features/issue-deprication-warning-for-python-smaller-3-8 branch August 28, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants