Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tests for BEV facades #142

Merged
merged 53 commits into from
Dec 4, 2023
Merged

Tests for BEV facades #142

merged 53 commits into from
Dec 4, 2023

Conversation

SabineHaas
Copy link
Member

@SabineHaas SabineHaas commented Nov 13, 2023 •
edited
Loading

Description

Adds tests for the BEV-facade, being developed in #94. For a full list of tests see #139

Fixes #139

Type of change

Please tick or delete options that are not relevant.

  • Bug fix: move conversion_factors of v2g converter and commodity_converter to output flows
  • New feature: Tests for BEV-facade (dispatch)
  • New feature: Tests for BEV-facade (investment)

Checklist:

Please tick or delete options that are not relevant.

  • New and adjusted code is formatted using the pre-commit hooks
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • If new packages are needed, I added them the setup.py
  • I have added new features/fixes to the CHANGELOG
  • I have added my name to AUTHORS

@SabineHaas SabineHaas requested a review from nailend November 13, 2023 14:15
@SabineHaas SabineHaas self-assigned this Nov 13, 2023
@nailend nailend changed the base branch from dev to feature/battery-electric-vehicle November 13, 2023 15:02
@SabineHaas
Adapt bev facade v2g tests
e6dfe63
@SabineHaas
Remove unnecessary code and solved todos
afbd8fd
@SabineHaas
Add docstring describing test_bev_v2g_dispatch
2e559c8
@SabineHaas
Rename initial storage level as named in BEV class: initial_storage_c…
6af1fa2 
…apacity
@SabineHaas
Uncomment availability in commodity converter and storage
03cbb5a
@SabineHaas
Add todo and correction
0a0c0cf
@SabineHaas
Add test case for v2g, inflex, g2v trio - note: adaptions needed
0ded9cc
@SabineHaas
Add test case for bev inflex facade - note: adaptions needed
1e6b39b
@SabineHaas
Adapt bev inflex test and add description
3ac45c2
@SabineHaas
Add bev g2v dispatch test
32ea252
@SabineHaas
Adapt bev trio (v2g, g2v, inflex) test
9cc74c2
@SabineHaas
Add description to test_bev_trio_dispatch()
0f737d2
@SabineHaas
Move variable_costs to input flow of storage also for expandable=False
1bd1569
@SabineHaas
Add test class and first test case for BEV investment tests
68eaf44
@SabineHaas
Rename test class for bev dispatch tests to TestBevFacadesDispatch
5bdc4d3
@SabineHaas
Add solving of test case and first assertion
f20244d
@SabineHaas
Add lines for constraints
c22fc19
@SabineHaas
Corrections
246ee4b
@SabineHaas SabineHaas mentioned this pull request Nov 30, 2023
Open
@SabineHaas
Copy link
Member Author

@nailend this PR is ready to review.
This PR should be merged before you go on working on PR #94 to avoid merge conflicts.
I have opened issue #144, to remind us of the tests that need adaptions.

nailend and others added 15 commits December 4, 2023 13:20
@nailend
Change 0.0 to 0 in some lp files
703cac4 
After a previous pyomo update some 0 value had to be
changed to 0.0. After a new update, this changes back.
@nailend
Add changelog entry
032ba55
@nailend
Fix missed 0
2b5fc4e
@nailend
Merge pull request #148 from oemof/fix/adjust-lp-files-to-pyomo6.7
e218b83 
Update lp files for pyomo6.7
@nailend
Remove equal-invest constraint from bev constraint lp test
7472a15 
The equal-invest constraint is not necessary anymore as
the flow through the bev-facade is already restricted by the
storage in & outflow. Costs are only applied for the storage.
@nailend
Revert "Remove equal-invest constraint from bev constraint lp test"
7a9d9da 
Although not necessary, we constraint will still be applied to check
the lp files.
This reverts commit 7472a15.
@nailend
Add timesteps to docstring
9eb57a9
@nailend
Add lines to table in docstrings
0c37c8a
@nailend
Add explanation on invest constraint
7410421
@nailend
Adapt bev constraint test
83f3ab7
@nailend
Remove bev multi-period constraint test
a64ef1e 
This test is not necessary as there are no further features
compared to the single period one.
@nailend
Add bev trio constraint lp file
42223c2
@nailend
Merge branch 'dev' into feature/bev_tests
c7aadd1
@nailend
Rename lp file
9774aea
@nailend
Update lp file
3ea89f9
nailend
nailend approved these changes Dec 4, 2023
View reviewed changes
Copy link
Collaborator

@nailend nailend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thanks a lot for your work.

@nailend nailend merged commit 3d30c87 into feature/battery-electric-vehicle Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nailend nailend nailend approved these changes

Assignees

@SabineHaas SabineHaas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add tests for BEV-component
2 participants
@SabineHaas @nailend