-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Plotting T-s diagram #514
Plotting T-s diagram #514
Conversation
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Hello @Nzb0731! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:
Comment last updated at 2024-05-23 17:52:26 UTC |
Hi @Nzb0731, thank you for your contribution. I'll review the PR this week and let you know, how to proceed. Best Francesco |
Thanks for your contribution @Nzb0731, I made some smaller modifications (better spaced isobars and some isenthalpics) and added a darkmode figure as well. I will also make some minor changes to fluprodia to enable compatibility to darkmode plotting with matplotlib. |
Hi @fwitte, Thank you for approving the PR and for the modifications to make this feature better. I am also grateful for the open-source model, which has enabled me to complete my final year project. Best wishes, |
General
I am a chemical engineering student working on a final year project using TESPy to study modelling of Rankine cycles.
During my studies, I generate a T-s diagram to the Rankine cycle model using the fluprodia package, as recommended in the documentation. This is useful for analysis purposes, e.g., to validate the correctness of the model. For example, if the T-s diagram does not form a closed-loop, there could be something wrong in the model.
We have also updated the documentation of Rankine cycles to reflect the changes. We thought this could be helpful to other users in the future, hence opening this PR.