Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plotting T-s diagram #514

Merged
merged 19 commits into from
May 23, 2024
Merged

Plotting T-s diagram #514

merged 19 commits into from
May 23, 2024

Conversation

Nzb0731
Copy link
Contributor

@Nzb0731 Nzb0731 commented May 21, 2024

General

I am a chemical engineering student working on a final year project using TESPy to study modelling of Rankine cycles.

During my studies, I generate a T-s diagram to the Rankine cycle model using the fluprodia package, as recommended in the documentation. This is useful for analysis purposes, e.g., to validate the correctness of the model. For example, if the T-s diagram does not form a closed-loop, there could be something wrong in the model.

We have also updated the documentation of Rankine cycles to reflect the changes. We thought this could be helpful to other users in the future, hence opening this PR.

Nzb0731 and others added 12 commits May 20, 2024 11:03
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
Co-authored-by: chonghe <44791194+chong-he@users.noreply.github.com>
@pep8speaks
Copy link

pep8speaks commented May 21, 2024

Hello @Nzb0731! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

Line 58:1: E402 module level import not at top of file
Line 59:1: E402 module level import not at top of file
Line 60:1: E402 module level import not at top of file

Comment last updated at 2024-05-23 17:52:26 UTC

@fwitte
Copy link
Member

fwitte commented May 21, 2024

Hi @Nzb0731,

thank you for your contribution. I'll review the PR this week and let you know, how to proceed.

Best

Francesco

@fwitte
Copy link
Member

fwitte commented May 23, 2024

Thanks for your contribution @Nzb0731, I made some smaller modifications (better spaced isobars and some isenthalpics) and added a darkmode figure as well. I will also make some minor changes to fluprodia to enable compatibility to darkmode plotting with matplotlib.

@fwitte fwitte merged commit fbe3de1 into oemof:dev May 23, 2024
8 checks passed
@Nzb0731
Copy link
Contributor Author

Nzb0731 commented May 24, 2024

Hi @fwitte,

Thank you for approving the PR and for the modifications to make this feature better. I am also grateful for the open-source model, which has enabled me to complete my final year project.

Best wishes,
Zhen Bin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants