[ENH] revisions to @oesteban's Alternative proposal to BEP038 #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- atlas/tpl can't be used at the same time - relax requirement of cohort directory - remove language of cohort as 'dual' to session - remove references to provenance (out of scope, imo)
effigies
reviewed
Nov 19, 2024
| @@ -289,6 +289,7 @@ If you contributed to the BIDS ecosystem and your name is not listed, please add | |||
| | Parul Sethi | 📖🔧⚠️💻 | | |||
| | Patricia Clement | 💬🐛💻📖🔣💡📋🤔📆⚠️📢 | | |||
| | Patrick Park | 📖💡💬💻 | | |||
| | Paul Wighton | 📖 | | |||
There was a problem hiding this comment.
@pwighton To avoid losing this to a reversion, please update https://github.com/bids-standard/bids-specification/wiki/Recent-Contributors, as this page is auto-generated from a source during the release process.
There was a problem hiding this comment.
Thanks @effigies, I just updated that page.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These revisions are based off of a conversation with @oesteban and @mnoergaard in which it was clarified that an atlas is an aggregation of nominal (discreet-valued) data and a template is an aggregation of ordinal (continuous-valued) data.
The distinction between atlas template is clarified
Original proposal seemed to imply it's an altas/template only if it aggregates over more than one subject, otherwise the
sub-<label>is used. This has been removed as it seems unnecessary and introduced complications (e.g In the colin27 example, it is not clear from the filname thatsub-01_T1w.nii.gzis an aggregation of data across 27 scans) This should be incorporated into the definition if it is to be re-introducedRemoves the concept of 'derived from' from the definition of atlas. Provenance should be considered out of scope of this spec, imo
Removes references to "original default or implicit atlas". I don't think this concept is necessary, but if it is, it should be formally defined.
Reworked examples:
_desg,_probsegor_maskit's an atlas_pet, it's a templateatlas-ps13_res-2_space-fsaverage_desc-nopvc_dseg.tsvin the PS13 example Is an aggregation of the data inatlas-ps13_res-2_space-fsaverage_stat-mean_desc-nopvc_mimap.nii.gz, using the ROIs inatlas-fsaverage_dseg.nii.gzto define how the data is aggregated. This file is now calledtpl-ps13_seg-fsaverage_pet.tsvin this PR since it's an aggregation of continuous-valued data.