Notify when a property is not available, and skip to the next dataset. #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t, log it and continue
oetiker
approved these changes
Oct 9, 2018
|
sorry missed the context ... getting a warning every time around does not seem all that good a solution either ... since this one property is fine in the context of #154 |
|
I am running it right now, and I am only getting a warning when the service is reloaded or started (which is the only moment when the backup plan is refreshed). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a property on a dataset is not available, znapzend dies with an error message. This PR changes that by a warning and the skipping of that dataset. By doing this, we can set org.znapzend properties on descendant datasets (specifically thinking on the org.znapzend:enable, to skip those datasets that have it set to "off" when coming from a recursive parent).