Handle not-sending of not-enabled datasets #626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of org.znapzend:enabled" for sub-datasets Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… cleanup of snapshots on enabled=off sub-datasets Signed-off-by: Jim Klimov <jimklimov@gmail.com>
…teSnapshot() so it can also be used in sendRecvCleanup() Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… done in refreshBackupPlans() once
Track the list of names as @{$backupSet->{srcDisabledDescendants}}
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
Signed-off-by: Jim Klimov <jimklimov@gmail.com>
This was referenced Jan 16, 2024
|
hmmm sorry ... this is getting a bit complex now aren't you changeing the same function as in the other PR ? |
As noted in the other PR at #625 - indeed, same function but for a different purpose. The change here merely skips sending of datasets that are "not-enabled" by whatever definition of that is in the codebase. That other PR changes the definition. Also both of these PRs include and supersede the less impactful changes proposed in #623 (at least, as of when it did not include numerous merge-backs from master-branch updates). |
oetiker
requested changes
Mar 11, 2024
…a not-enabled dataset Signed-off-by: Jim Klimov <jimklimov@gmail.com>
… emit a debug message about sending (or not) a dataset Signed-off-by: Jim Klimov <jimklimov@gmail.com>
oetiker
approved these changes
Mar 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows up from ideas in #623
UPDATE: There was a thought about using
oracleModeto fall back from a recursive snapshot send to one-by-one processing in case we have exclusions (and/or send recursively only some smaller sub-trees that are safe to send - no exclusions there), but looking at this code structure I do not see a recursive send in fact. Maybe it is hidden deeper in$self->zZFS->...?..