Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose washing machine program code if available #215

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

ofalvai
Copy link
Owner

@ofalvai ofalvai commented Nov 14, 2022

No description provided.

@codecov
Copy link

codecov bot commented Nov 14, 2022

Codecov Report

Merging #215 (e11b39c) into main (6b21deb) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #215      +/-   ##
==========================================
+ Coverage   97.98%   98.00%   +0.01%     
==========================================
  Files           7        7              
  Lines         597      602       +5     
==========================================
+ Hits          585      590       +5     
  Misses         12       12              
Impacted Files Coverage Δ
custom_components/candy/client/model.py 99.20% <100.00%> (+<0.01%) ⬆️
custom_components/candy/sensor.py 98.87% <100.00%> (+<0.01%) ⬆️
custom_components/candy/client/__init__.py 97.22% <0.00%> (+0.07%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ofalvai ofalvai merged commit ef5b1b1 into main Nov 14, 2022
@ofalvai ofalvai deleted the washing-machine-program-code branch November 14, 2022 09:15
@mh166
Copy link

mh166 commented Nov 17, 2022

@ofalvai I'm curious: what is program_code used for? Or what does it describe?

I tested with my washing machine and found, that there is a 1:1 relation between program and program_code.

Program Program code
1 136
2 135
3 8
4 40
... ...

If both of them uniquely identify a certain program, why are there two attributes in the first place? I thought, maybe program could refer to this model's programs, as it is strictly increasing with each step on the "menu dial" (don't know the english word 😅). And perhaps program_code is a universal identifier over all of Candy's washing machines? Other than that, I can't imagine a valid reason for the existance of both attributes simultaneously...

I know that you are only providing the integration and not the firmware for the washing machine (although it would be nice 😉). But still, maybe you have an idea what it might be used for. :)

@ofalvai
Copy link
Owner Author

ofalvai commented Nov 19, 2022

Good questions, I was wondering about the same. I noticed that some of the programs on my washing machine can have the same Program but report different Program codes.

@mh166
Copy link

mh166 commented Nov 25, 2022

Oh okay. For me, so far, Program and Program code have a 1:1 mapping. But if that's not the case for you, I get why you publish this attribute. Thanks for the clarification. 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants