-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend tumble dryer support #22
Conversation
@@ -115,15 +118,28 @@ class TumbleDryerStatus: | |||
program: int | |||
remaining_minutes: int | |||
remote_control: bool | |||
dry_level: int | |||
refresh: bool |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the meaning of this bool value? Is this an extra feature on top of programs?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a tumble dryer features. There are more dry level (as ready to be ironing or to be put in the closet) and when the machine is running reach step by step these level. You can choose to pull out some clothes (as shirts that need to be ironed) and leave t-shirt to be so dry to fold in the closet, for example.
Refresh is a feature that you can turn on to keep machine running time-by-time, so clothes don't crease.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution, it's really cool :) I had a couple of comments about naming things, I want to fully understand what each field means so that I can touch the code later without having to buy a tumble dryer :)
Oh and there is one failing test case now that the sensor attributes have changed. Your pull request didn't trigger the GitHub workflow that runs the tests, but I think I fixed the triggers on the main branch. It should work if you pull and merge the main branch and push the commit to this PR.
You're welcome. I've just fetched from upstream, should be ok. Let me know if you need more changes or infos. |
Thank you, the changes look good, but there is still one failing test case. |
I cannot find what it's wrong. Any advice? |
A test case in |
I've added the missing attributes but you need to approve my commit in order to pass the test I guess. |
It's still not passing the test case for some reason, I recommend running the tests locally to find out more. Activate the Python virtual env, then |
Finally fix'd |
Codecov Report
@@ Coverage Diff @@
## main #22 +/- ##
==========================================
+ Coverage 86.66% 87.99% +1.32%
==========================================
Files 6 6
Lines 405 458 +53
==========================================
+ Hits 351 403 +52
- Misses 54 55 +1
Continue to review full report at Codecov.
|
Awesome, thank you so much for the contribution! |
I’ve extended support to tumble dryer and it translation.