Tumble Dryer - Improve DryLevel #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Aded DryLevelState class. Several tests.
Codecov Report
@@ Coverage Diff @@
## main #29 +/- ##
==========================================
- Coverage 88.82% 88.68% -0.15%
==========================================
Files 6 6
Lines 555 592 +37
==========================================
+ Hits 493 525 +32
- Misses 62 67 +5
Continue to review full report at Codecov.
|
Closed
ofalvai
reviewed
Oct 17, 2021
| @@ -132,11 +156,11 @@ def from_json(cls, json): | |||
| return cls( | |||
| machine_state=MachineState(int(json["StatoTD"])), | |||
| program_state=DryerProgramState(int(json["PrPh"])), | |||
| dry_level_state=DryLevelState(int(json["DryingManagerLevel"])), | |||
| program=int(json["Pr"]), | |||
| remaining_minutes=int(json["RemTime"]), | |||
| remote_control=json["StatoWiFi"] == "1", | |||
| dry_level=int(json["DryLev"]), | |||
There was a problem hiding this comment.
I suggest calling this target_dry_level to make it obvious the difference
ofalvai
reviewed
Oct 17, 2021
| @@ -202,10 +203,12 @@ def extra_state_attributes(self) -> Mapping[str, Any]: | |||
|
|
|||
| attributes = { | |||
| "program": status.program, | |||
| "machine_state": str(status.machine_state), | |||
| "program_state": str(status.program_state), | |||
| "dry_level_state": str(status.dry_level_state), | |||
There was a problem hiding this comment.
Suggested change
| "dry_level_state": str(status.dry_level_state), | |
| "current_dry_level": str(status.dry_level_state), |
ofalvai
reviewed
Oct 17, 2021
| 'icon': 'mdi:tumble-dryer' | ||
| } | ||
|
|
||
|
|
||
| async def test_sensors_device_info(hass: HomeAssistant, aioclient_mock: AiohttpClientMocker): |
There was a problem hiding this comment.
Please add the new sensor to this test case too
ofalvai
requested changes
Oct 17, 2021
|
I'm closing this PR as #32 added support for the same thing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've created a mapper for DryLevel with the values found in candy simply-fi code.
I've improved the DryLevel state by creating a new sensor (dryer_current_dry_level). This could be usefull to create automations based in the dry level of the machine.
Also i've added several new tests for the machine.