Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing links to github repos with #442

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

Conversation

Depact
Copy link

@Depact Depact commented Sep 11, 2024

Point of this PR is to make it easier to get basic idea about repos without need to opening them.

This PR changes links to github repos to procedural repos cards using GitHub Readme Stats project

Check my repo in order to see how to looks. I made those cards clickable

Used VS Code regex functionality to perform those changes

^(.* \[\*\*([a-zA-Z0-9 -]*)\*\*\]\((https://github.com/([a-zA-Z0-9 -]*)/([a-zA-Z0-9 -]*))\)(.*))$

* $6\n[![Readme Card](https://github-readme-stats.vercel.app/api/pin/?username=$4\&repo=$5&cache_seconds=86400&heme=vision-friendly-dark)]($3)
\* \n
*

Project with cards have different themes.
https://github.com/anuraghazra/github-readme-stats?tab=readme-ov-file#themes

@Depact
Copy link
Author

Depact commented Sep 11, 2024

Okay, I need help with figuring out what's wrong with markdownlint

@offa
Copy link
Owner

offa commented Sep 12, 2024

Thanks for your submission.

There are some drawbacks of this design:

  • It fully relies on a third party service and it's availability
  • It breaks the layout, especially as there are non-Github projects
  • Adding a link is not trivially anymore
  • It seems not to work with different Github colour schemes
  • Each entry is now many times larger (especially in height)

@Depact
Copy link
Author

Depact commented Sep 13, 2024

@offa but with this approach it's way easier to use it.

@offa
Copy link
Owner

offa commented Sep 13, 2024

I'm just not so sure about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants