Use optional for the engine path #5575
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Disservin
commented
Sep 7, 2024
•
Disservin
commented
- A small quality of file change is to change the type of engine path from a string to an optional string, skips the binary directory lookup, which is commonly disabled by people who create wasm builds or include stockfish as a library.
|
Only global variables within a single translation units are initialized in specified order. If your code is placed in a different translation unit it is not guaranteed that |
|
Ah right.. mh |
Disservin
force-pushed
the
refactor-initialization
branch
from
051bcb0
to
f5cfe93
Compare
skystarspython
pushed a commit
to official-pikafish/Pikafish
that referenced
this pull request
Sep 14, 2024
- A small quality of file change is to change the type of engine path from a string to an optional string, skips the binary directory lookup, which is commonly disabled by people who create wasm builds or include stockfish as a library. closes official-stockfish/Stockfish#5575 No functional change
skystarspython
pushed a commit
to official-pikafish/Pikafish
that referenced
this pull request
Nov 3, 2024
- A small quality of file change is to change the type of engine path from a string to an optional string, skips the binary directory lookup, which is commonly disabled by people who create wasm builds or include stockfish as a library. closes official-stockfish/Stockfish#5575 No functional change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.