Port instrumented.sh testing to python #5583
Closed
+904
−302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
nice, any particular requirements/packages to use this or all standard library? |
Apart from the python version requirement that i listed, no. All packages should be standard ones |
Disservin
force-pushed
the
python-testing-pr
branch
2 times, most recently
from
16bf7a2
to
1aa8d0c
Compare
Since an unknown amount of time the instrumented CI has been a bit flawed, explained here official-stockfish#5185. It also experiences random timeout issues where restarting the workflow fixes it or very long run times (more than other workflows) and is not very portable. The intention of this commit is to port the instrumented.sh to python which also works on other operating systems. It should also be relatively easy for beginners to add new tests to assert stockfish's output and to run it. From the source directory the following command can be run. `python3 ../tests/instrumented.py --none ./stockfish` A test runner will go over the test suites and run the test cases. All instrumented tests should have been ported over. The required python version for this is should be 3.7 (untested), testing.py includes some infrastructure code which setups the testing. fixes official-stockfish#5185 closes official-stockfish#5583 No functional change
Disservin
force-pushed
the
python-testing-pr
branch
from
1aa8d0c
to
ebf4f19
Compare
Disservin
changed the title
|
requires the package |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since an unknown amount of time the instrumented CI has been a bit flawed, explained here #5185. It also experiences random timeout issues where restarting the workflow fixes it or very long run times (more than other workflows) and is not very portable.
The intention of this PR is to propose a port to python which also works on other operating systems.
It should also be relatively easy for beginners to add new tests to assert stockfish's output and to run it.
From the source directory the following command can be run, to run the unit tests.
python3 ../tests/instrumented.py --none ./stockfish.A test runner will go over the test suites and run the test cases. Producing an output which looks like this
All instrumented tests should have been ported over.
I think the required python version for this is 3.7, testing.py includes some infrastructure code which setups the testing.
No functional change