No comments count fetching on PTs #2145
Open
+10
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when fetching comments using the GitHub API, all the comment in between the two commits of master and SF16 are considered, this number might not be actually be interesting info or representitve, and since we fetch it each time with a refresh since we expect the comments count to update at any time, but not for PTs., that leads to wasteful API rate-limit usage. Example: https://tests.stockfishchess.org/tests/view/668d79ae5034141ae5999e45 closes official-stockfish#2123
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when fetching comments using the GitHub API, all the comment in between the two commits of master and SF16 are considered, this number might not be actually be interesting info or representitve, and since we fetch it each time with a refresh since we expect the comments count to update at any time, but not for PTs., that leads to wasteful API rate-limit usage.
Example: https://tests.stockfishchess.org/tests/view/668d79ae5034141ae5999e45