Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: drop support for Python 2, drop requirement for six package #539

Merged
merged 3 commits into from
Feb 28, 2020

Conversation

whtsky
Copy link
Collaborator

@whtsky whtsky commented Feb 22, 2020

No description provided.

@codecov
Copy link

codecov bot commented Feb 22, 2020

Codecov Report

Merging #539 into master will decrease coverage by 1.05%.
The diff coverage is 84.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #539      +/-   ##
==========================================
- Coverage   90.32%   89.26%   -1.06%     
==========================================
  Files          28       28              
  Lines        1437     1435       -2     
==========================================
- Hits         1298     1281      -17     
- Misses        139      154      +15
Impacted Files Coverage Δ
werobot/crypto/exceptions.py 100% <ø> (ø) ⬆️
werobot/crypto/__init__.py 92.85% <ø> (-0.13%) ⬇️
werobot/parser.py 100% <ø> (ø) ⬆️
werobot/logger.py 50% <0%> (+5.1%) ⬆️
werobot/messages/messages.py 100% <100%> (ø) ⬆️
werobot/utils.py 100% <100%> (ø) ⬆️
werobot/messages/events.py 100% <100%> (ø) ⬆️
werobot/robot.py 86.75% <100%> (-0.57%) ⬇️
werobot/client.py 98.07% <100%> (+0.03%) ⬆️
werobot/session/saekvstorage.py 46.66% <0%> (-53.34%) ⬇️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 184286b...fcd29d6. Read the comment docs.

@TravisBuddy
Copy link

Hey @whtsky,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 6b797070-558a-11ea-850c-e5458713aaa0

@TravisBuddy
Copy link

Hey @whtsky,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: b6099c80-5596-11ea-850c-e5458713aaa0

@whtsky
Copy link
Collaborator Author

whtsky commented Feb 22, 2020

好像不能把非 Draft PR 转成 Draft

@whtsky whtsky changed the title refactor: drop support for Python 2, drop requirement for six package WIP: refactor: drop support for Python 2, drop requirement for six package Feb 22, 2020
tests/test_session.py Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
.circleci/config.yml Show resolved Hide resolved
@whtsky whtsky force-pushed the drop_py2 branch 2 times, most recently from 2d5524c to ffed35d Compare February 23, 2020 10:36
@whtsky whtsky changed the title WIP: refactor: drop support for Python 2, drop requirement for six package refactor: drop support for Python 2, drop requirement for six package Feb 23, 2020
@TravisBuddy
Copy link

Hey @whtsky,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 3070e930-562b-11ea-8ad8-19cca21d7143

Copy link
Collaborator

@helloqiu helloqiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

感觉是不是还得更新一下文档和 CHANGELOG

@TravisBuddy
Copy link

Hey @whtsky,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 908d6020-59ad-11ea-822e-0bf67ba4204b

@whtsky whtsky self-assigned this Feb 28, 2020
@whtsky
Copy link
Collaborator Author

whtsky commented Feb 28, 2020

周末看

@whtsky whtsky merged commit 130eed1 into master Feb 28, 2020
@whtsky whtsky deleted the drop_py2 branch February 28, 2020 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants