Kaolin Themes not working properly on native-comp

[jakebox]

Can't quite explain the source of this issue, but in summary loading any kaolin-theme loads a very wrong color scheme, and trying to load another theme does not work either, a full restart is required. This issue began after I installed gccemacs (in this case emacs-plus's build). Kaolin-themes still works on my laptop which has 27.1 installed. Quite disappointed as I really love kaolin-galaxy, kaolin-themes is a great project!

I am happy to provide more info if needed, please let me know, I'd love to help fix this issue. I don't know much about themes but I can't find any particular errors when manually evaluating kaolin-themes.el. I've attached a photo of what loading kaolin-galaxy looks like.

[ogdenwebb]

Well, it's pretty strange, but the issue is related to color-dark-p/color-light-p functions in kaolin-themes-lib.el based on functions from built-in color.el library in Emacs. In Emacs 28 color-name-to-rgb (or maybe color-srgb-to-lab) is getting a wrong argument - for some reason it gets a R G B list instead of hex triplet.

Maybe something changes in color.el or something is wrong related to frames or color-values function in Emacs 28.

[ogdenwebb]

Sorry for that. I'm kinda stupid, because I don't use kaolin-themes prefix for color-light-p and color-dark-p functions. -__-

This issues appears because from now Emacs 28 has these functions built-in in faces.el library, so it causes the conflict. Should be fixed now. 🎉

[jakebox]

Sorry, just got around to testing this out, and it seems to be fixed! Thanks for your reply and hard work. Glad to have my favorite colorschemes back.