Merge pull request #818 from tdakkota/fix/path-parameter-escaping

fix(gen): unescape path parameters correctly
ogen-go · Mar 16, 2023 · e329fad · e329fad
2 parents fae338e + 125095c
commit e329fad
Show file tree

Hide file tree

Showing 123 changed files with 31,591 additions and 18,738 deletions.
diff --git a/_testdata/positive/parameters.json b/_testdata/positive/parameters.json
@@ -141,27 +141,55 @@
         }
       }
     },
+    "/pathParameter/{value}": {
+      "get": {
+        "description": "Test for path param",
+        "operationId": "pathParameter",
+        "parameters": [
+          {
+            "name": "value",
+            "in": "path",
+            "required": true,
+            "schema": {
+              "type": "string"
+            }
+          }
+        ],
+        "responses": {
+          "200": {
+            "description": "Returns path value",
+            "content": {
+              "application/json": {
+                "schema": {
+                  "$ref": "#/components/schemas/Value"
+                }
+              }
+            }
+          }
+        }
+      }
+    },
     "/headerParameter": {
       "get": {
         "description": "Test for header param",
         "operationId": "headerParameter",
         "parameters": [
           {
+            "name": "X-Value",
             "in": "header",
             "required": true,
-            "name": "X-Auth-Token",
             "schema": {
               "type": "string"
             }
           }
         ],
         "responses": {
           "200": {
-            "description": "Returns sha256 of header value",
+            "description": "Returns header value",
             "content": {
               "application/json": {
                 "schema": {
-                  "$ref": "#/components/schemas/Hash"
+                  "$ref": "#/components/schemas/Value"
                 }
               }
             }
@@ -175,21 +203,21 @@
         "operationId": "cookieParameter",
         "parameters": [
           {
+            "name": "value",
             "in": "cookie",
             "required": true,
-            "name": "value",
             "schema": {
               "type": "string"
             }
           }
         ],
         "responses": {
           "200": {
-            "description": "Returns sha256 of cookie value",
+            "description": "Returns cookie value",
             "content": {
               "application/json": {
                 "schema": {
-                  "$ref": "#/components/schemas/Hash"
+                  "$ref": "#/components/schemas/Value"
                 }
               }
             }
@@ -280,21 +308,14 @@
   },
   "components": {
     "schemas": {
-      "Hash": {
+      "Value": {
         "type": "object",
         "required": [
-          "raw",
-          "hex"
+          "value"
         ],
         "properties": {
-          "raw": {
-            "type": "string",
-            "format": "byte"
-          },
-          "hex": {
-            "type": "string",
-            "minLength": 64,
-            "maxLength": 64
+          "value": {
+            "type": "string"
           }
         }
       },

diff --git a/examples/ex_2ch/oas_client_gen.go b/examples/ex_2ch/oas_client_gen.go