-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add 'mac' primitive for 'net.HardwareAddr' (MAC) #1165
feat: add 'mac' primitive for 'net.HardwareAddr' (MAC) #1165
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1165 +/- ##
==========================================
+ Coverage 72.47% 73.79% +1.32%
==========================================
Files 187 188 +1
Lines 15049 12659 -2390
==========================================
- Hits 10907 9342 -1565
+ Misses 3608 2784 -824
+ Partials 534 533 -1 ☔ View full report in Codecov by Sentry. |
d8e6968
to
094db93
Compare
Forced pushed with some more changes I discovered by just global searching for Guess I need to alter one of the spaces with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Format should be handled here too:
Line 126 in 092ca33
switch f := s.Format; f { |
67ea6eb
to
ad93fd3
Compare
ad93fd3
to
d87b678
Compare
Very simple PR that adds a new string primitive
mac
to be interpreted as anet.HardwareAddr
, just likeip
->netip.Addr
.Marking as draft as I haven't added any integration test for the generator. I wonder where that should go. Should I create a new spec in the
_testdata
folder or add to an existing one? Also not suer about theArray
functions. Those exist for theUUID
primitive but not for e.g. theIP
one? Why is that?Anything I need to keep in mind?
If I can get this landed, I'll send a PR to the docs repo, as well.
Cheers!