fix(gen): add support for Free-form Objects when a schema definitions only specifies type: object
#1246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1246 +/- ##
==========================================
- Coverage 73.85% 73.82% -0.04%
==========================================
Files 189 189
Lines 12807 12809 +2
==========================================
- Hits 9459 9456 -3
- Misses 2802 2808 +6
+ Partials 546 545 -1 ☔ View full report in Codecov by Sentry. |
tdakkota
approved these changes
May 22, 2024
k4n4ry
force-pushed
the
fix/generate-free-form-object
branch
from
e9cb36b to
1c28226
Compare
|
@tdakkota |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1221
If the target schema does not have
AdditionalPropertiesspecified, we treathasAdditionalPropsas true only when bothPropertiesandPatternPropertiesare absent.