Fix duplicate variable name with multiple oauth2 security schemes #1304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1304 +/- ##
=======================================
Coverage 73.92% 73.92%
=======================================
Files 189 189
Lines 12855 12855
=======================================
Hits 9503 9503
Misses 2804 2804
Partials 548 548 ☔ View full report in Codecov by Sentry. |
tdakkota
approved these changes
Sep 5, 2024
johnrutherford
force-pushed
the
multiple-oauth2-schemes
branch
from
7456a9a to
b603d86
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you have an OpenAPI spec that defines more than one oauth2 security scheme, the will each generate an
oauth2Scopesvariable in oas_security_gen.go, and the duplicate variable names will not compile.This fixes the issue by appending the unique name of the security scheme to the variable name so there will not be a conflict.