-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(gen): support custom time format #1334
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1334 +/- ##
==========================================
- Coverage 71.45% 71.44% -0.01%
==========================================
Files 190 190
Lines 15584 15587 +3
==========================================
+ Hits 11135 11136 +1
Misses 3898 3898
- Partials 551 553 +2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
Please move generated code changes to a separate commit.
Also, it would be nice to have a encode-decode-encode test for this feature, like one of these.
Everything else LGTM.
d015940
to
7be7d2b
Compare
@tdakkota Weirdly when testing on my Intel MacBook I can reproduce similar results as you on the benchmarks. On my M1 Since we're leaving the Also, I had forgotten to add support for parameters so I added that too. Let me know if there's anything else. |
7be7d2b
to
ac2390e
Compare
ac2390e
to
dbd90b0
Compare
This PR adds support for a new extension
x-ogen-time-format
which sets a format for encoding and decoding time values.Also fixes some indentation on templates (mix of tabs and spaces).
Since I'm not that familiar with the codebase, let me know if I should do some things differently.
Closes #1063