Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(middleware): reduce chain allocation #561

Merged
merged 3 commits into from
Sep 12, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Sep 12, 2022

Benchstat:

name                old time/op    new time/op    delta
ChainMiddlewares-4    2.69µs ± 2%    1.29µs ± 2%  -52.01%  (p=0.000 n=13+15)

name                old alloc/op   new alloc/op   delta
ChainMiddlewares-4    1.57kB ± 0%    0.48kB ± 0%  -69.39%  (p=0.000 n=15+15)

name                old allocs/op  new allocs/op  delta
ChainMiddlewares-4      39.0 ± 0%      20.0 ± 0%  -48.72%  (p=0.000 n=15+15)

Benchstat:
```
name                old time/op    new time/op    delta
ChainMiddlewares-4    2.69µs ± 2%    1.29µs ± 2%  -52.01%  (p=0.000 n=13+15)

name                old alloc/op   new alloc/op   delta
ChainMiddlewares-4    1.57kB ± 0%    0.48kB ± 0%  -69.39%  (p=0.000 n=15+15)

name                old allocs/op  new allocs/op  delta
ChainMiddlewares-4      39.0 ± 0%      20.0 ± 0%  -48.72%  (p=0.000 n=15+15)
```
@codecov
Copy link

codecov bot commented Sep 12, 2022

Codecov Report

Base: 72.66% // Head: 72.66% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (806922f) compared to base (f6f6b4d).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   72.66%   72.66%           
=======================================
  Files         157      157           
  Lines       11082    11083    +1     
=======================================
+ Hits         8053     8054    +1     
  Misses       2609     2609           
  Partials      420      420           
Impacted Files Coverage Δ
middleware/middleware.go 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as ready for review September 12, 2022 12:53
@shadowspore shadowspore merged commit 2740b2e into ogen-go:main Sep 12, 2022
@tdakkota tdakkota deleted the perf/optimize-chain branch September 12, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants