fix(gen): generate a special type for optional request body #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ernado
approved these changes
Sep 19, 2022
Add an empty body variant to the request sum type.
tdakkota
force-pushed
the
fix/handle-optional-body-correctly
branch
from
ef0b0af to
34e0d53
Compare
auto-merge was automatically disabled
September 19, 2022 20:44
Pull request was converted to draft
Otherwise, generate a `EmptyBody` case.
tdakkota
force-pushed
the
fix/handle-optional-body-correctly
branch
from
34e0d53 to
4b8ca26
Compare
Codecov ReportBase: 72.10% // Head: 72.09% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #577 +/- ##
==========================================
- Coverage 72.10% 72.09% -0.02%
==========================================
Files 159 159
Lines 11307 11338 +31
==========================================
+ Hits 8153 8174 +21
- Misses 2731 2739 +8
- Partials 423 425 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.