Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(gen): add multierr to header import list #588

Merged
merged 1 commit into from
Sep 24, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

Now `goimports` don't need to search it.
@tdakkota tdakkota marked this pull request as draft September 24, 2022 07:06
@codecov
Copy link

codecov bot commented Sep 24, 2022

Codecov Report

Base: 72.39% // Head: 72.40% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (599099a) compared to base (e1e138f).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #588      +/-   ##
==========================================
+ Coverage   72.39%   72.40%   +0.01%     
==========================================
  Files         160      160              
  Lines       11449    11449              
==========================================
+ Hits         8288     8290       +2     
+ Misses       2732     2731       -1     
+ Partials      429      428       -1     
Impacted Files Coverage Δ
gen/gen_contents.go 72.88% <0.00%> (+0.67%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as ready for review September 24, 2022 07:29
@ernado ernado merged commit 645258a into ogen-go:main Sep 24, 2022
@tdakkota tdakkota deleted the fix/add-multierr-to-header branch September 24, 2022 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants