Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): initial webhook support #622

Merged
merged 14 commits into from
Oct 18, 2022
Merged

feat(gen): initial webhook support #622

merged 14 commits into from
Oct 18, 2022

Conversation

tdakkota
Copy link
Member

For #592.

@tdakkota tdakkota force-pushed the feat/webhooks branch 2 times, most recently from 446d286 to 64f2f4d Compare October 12, 2022 22:28
@codecov
Copy link

codecov bot commented Oct 12, 2022

Codecov Report

Base: 73.87% // Head: 73.77% // Decreases project coverage by -0.09% ⚠️

Coverage data is based on head (7fdceaf) compared to base (bef1a77).
Patch coverage: 69.36% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #622      +/-   ##
==========================================
- Coverage   73.87%   73.77%   -0.10%     
==========================================
  Files         169      169              
  Lines       11547    11698     +151     
==========================================
+ Hits         8530     8630     +100     
- Misses       2582     2622      +40     
- Partials      435      446      +11     
Impacted Files Coverage Δ
otelogen/tracer.go 50.00% <0.00%> (-50.00%) ⬇️
gen/generator.go 57.05% <51.85%> (-10.32%) ⬇️
gen/router.go 86.95% <78.04%> (-7.17%) ⬇️
gen/gen_operation.go 85.71% <100.00%> (+0.52%) ⬆️
gen/ir/operation.go 79.16% <100.00%> (+6.19%) ⬆️
gen/templates.go 82.73% <100.00%> (+0.63%) ⬆️
gen/write.go 88.73% <100.00%> (+0.32%) ⬆️
openapi/parser/parse_webhook.go 100.00% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the feat/webhooks branch 3 times, most recently from 1c4ca91 to a9e3c97 Compare October 17, 2022 01:05
@tdakkota tdakkota marked this pull request as ready for review October 18, 2022 06:39
@ernado ernado merged commit 1abe8da into main Oct 18, 2022
@ernado ernado deleted the feat/webhooks branch October 18, 2022 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants