Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: print pretty error for external references #637

Merged
merged 2 commits into from
Oct 20, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Base: 73.77% // Head: 73.82% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (a848dac) compared to base (f6e7169).
Patch coverage: 82.71% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #637      +/-   ##
==========================================
+ Coverage   73.77%   73.82%   +0.04%     
==========================================
  Files         169      169              
  Lines       11699    11751      +52     
==========================================
+ Hits         8631     8675      +44     
- Misses       2622     2628       +6     
- Partials      446      448       +2     
Impacted Files Coverage Δ
gen/options.go 16.66% <ø> (ø)
jsonschema/parser_settings.go 77.77% <ø> (ø)
openapi/parser/settings.go 100.00% <ø> (ø)
jsonschema/resolve.go 62.50% <48.00%> (-2.89%) ⬇️
openapi/parser/resolve.go 89.14% <51.61%> (-1.51%) ⬇️
jsonschema/parser.go 83.42% <73.33%> (+0.13%) ⬆️
internal/location/error.go 72.61% <75.67%> (+5.95%) ⬆️
internal/location/position.go 78.35% <80.00%> (ø)
gen/errors.go 64.28% <100.00%> (ø)
gen/gen_contents.go 72.88% <100.00%> (ø)
... and 27 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ernado ernado merged commit 558accf into ogen-go:main Oct 20, 2022
@tdakkota tdakkota deleted the refactor/location branch October 21, 2022 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants