Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ogen): support URL as spec path argument #647

Merged
merged 4 commits into from
Nov 2, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@tdakkota tdakkota force-pushed the feat/support-url-arg branch from 161cebd to 425b366 Compare October 27, 2022 14:36
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Base: 73.71% // Head: 74.09% // Increases project coverage by +0.37% 🎉

Coverage data is based on head (ba95ca2) compared to base (ec279a5).
Patch coverage: 65.95% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #647      +/-   ##
==========================================
+ Coverage   73.71%   74.09%   +0.37%     
==========================================
  Files         171      170       -1     
  Lines       11834    11842       +8     
==========================================
+ Hits         8724     8774      +50     
+ Misses       2660     2612      -48     
- Partials      450      456       +6     
Impacted Files Coverage Δ
gen/options.go 16.66% <ø> (ø)
jsonschema/resolve.go 62.50% <0.00%> (ø)
openapi/parser/settings.go 100.00% <ø> (ø)
gen/generator.go 57.31% <50.00%> (+0.26%) ⬆️
jsonschema/external.go 50.79% <52.45%> (+50.79%) ⬆️
openapi/parser/resolve.go 89.26% <75.00%> (+0.12%) ⬆️
internal/jsonpointer/resolve_ctx.go 92.10% <100.00%> (+0.55%) ⬆️
openapi/parser/parse_components.go 86.84% <100.00%> (ø)
openapi/parser/parse_webhook.go 100.00% <100.00%> (ø)
openapi/parser/parser.go 100.00% <100.00%> (ø)
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the feat/support-url-arg branch 6 times, most recently from fda3809 to 24531cf Compare October 28, 2022 17:47
@tdakkota tdakkota marked this pull request as ready for review October 31, 2022 10:14
@tdakkota tdakkota marked this pull request as draft October 31, 2022 18:16
@tdakkota tdakkota force-pushed the feat/support-url-arg branch from 24531cf to f7e9471 Compare November 1, 2022 16:19
@tdakkota tdakkota force-pushed the feat/support-url-arg branch from f7e9471 to 63b73f1 Compare November 1, 2022 21:05
Pretty print the parsing error.
@tdakkota tdakkota marked this pull request as ready for review November 2, 2022 12:23
@ernado ernado merged commit fa53e56 into ogen-go:main Nov 2, 2022
@tdakkota tdakkota deleted the feat/support-url-arg branch November 2, 2022 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants