Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(jsonschema): parse discriminator properly #679

Merged
merged 7 commits into from
Nov 17, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@tdakkota tdakkota force-pushed the fix/parse-discriminator-properly branch from 1c1f8cf to 172e634 Compare November 16, 2022 06:46
@codecov
Copy link

codecov bot commented Nov 16, 2022

Codecov Report

Base: 73.70% // Head: 73.82% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (31063c2) compared to base (56c1a52).
Patch coverage: 77.77% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #679      +/-   ##
==========================================
+ Coverage   73.70%   73.82%   +0.12%     
==========================================
  Files         172      172              
  Lines       12367    12455      +88     
==========================================
+ Hits         9115     9195      +80     
- Misses       2770     2778       +8     
  Partials      482      482              
Impacted Files Coverage Δ
jsonschema/schema.go 100.00% <ø> (ø)
gen/schema_gen_sum.go 70.56% <46.00%> (-2.13%) ⬇️
jsonschema/parser.go 85.01% <93.82%> (+1.58%) ⬆️
jsonschema/resolve.go 80.00% <100.00%> (+17.50%) ⬆️
openapi/parser/parse_schema.go 100.00% <100.00%> (ø)
schema_backcomp.go 93.00% <100.00%> (+0.07%) ⬆️
jsonschema/external.go 50.63% <0.00%> (+2.53%) ⬆️
jsonschema/errors.go 89.65% <0.00%> (+10.34%) ⬆️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as ready for review November 16, 2022 09:05
@tdakkota tdakkota marked this pull request as draft November 16, 2022 15:20
@tdakkota tdakkota force-pushed the fix/parse-discriminator-properly branch 3 times, most recently from b079cf3 to 0e5dfc8 Compare November 17, 2022 06:13
@tdakkota tdakkota marked this pull request as ready for review November 17, 2022 06:23
@tdakkota tdakkota force-pushed the fix/parse-discriminator-properly branch from 0e5dfc8 to 37abff7 Compare November 17, 2022 07:13
@tdakkota tdakkota force-pushed the fix/parse-discriminator-properly branch from 37abff7 to 31063c2 Compare November 17, 2022 07:16
@ernado ernado merged commit e501483 into ogen-go:main Nov 17, 2022
@tdakkota tdakkota deleted the fix/parse-discriminator-properly branch November 17, 2022 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants