Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): use RefKey as type storage key #680

Merged
merged 9 commits into from
Nov 22, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@tdakkota tdakkota requested a review from shadowspore November 17, 2022 11:43
@tdakkota tdakkota force-pushed the fix/use-refkey branch 3 times, most recently from 1142a79 to 5ab6b30 Compare November 17, 2022 19:11
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Base: 73.94% // Head: 74.07% // Increases project coverage by +0.12% 🎉

Coverage data is based on head (1ab8195) compared to base (85e9ab7).
Patch coverage: 91.17% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #680      +/-   ##
==========================================
+ Coverage   73.94%   74.07%   +0.12%     
==========================================
  Files         172      172              
  Lines       12485    12507      +22     
==========================================
+ Hits         9232     9264      +32     
+ Misses       2771     2762       -9     
+ Partials      482      481       -1     
Impacted Files Coverage Δ
gen/ir/type.go 76.00% <0.00%> (-0.62%) ⬇️
jsonschema/schema.go 100.00% <ø> (ø)
openapi/parameter.go 80.00% <ø> (ø)
gen/gen_schema.go 69.38% <88.88%> (+1.30%) ⬆️
openapi/parser/resolve.go 89.26% <89.28%> (ø)
internal/jsonpointer/resolve_ctx.go 96.38% <94.59%> (+4.38%) ⬆️
gen/gen_responses.go 69.46% <100.00%> (ø)
gen/genctx.go 90.62% <100.00%> (ø)
gen/names.go 90.20% <100.00%> (+0.13%) ⬆️
gen/reduce.go 75.00% <100.00%> (ø)
... and 16 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as ready for review November 18, 2022 07:07
@tdakkota tdakkota marked this pull request as draft November 18, 2022 09:37
@tdakkota tdakkota force-pushed the fix/use-refkey branch 8 times, most recently from cdf88b7 to 3b5f056 Compare November 20, 2022 21:49
@tdakkota tdakkota marked this pull request as ready for review November 22, 2022 21:23
@ernado ernado merged commit 8778abf into ogen-go:main Nov 22, 2022
@tdakkota tdakkota deleted the fix/use-refkey branch November 22, 2022 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants