Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): avoid empty response types (part 3) #724

Merged
merged 3 commits into from
Dec 14, 2022

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented Dec 14, 2022

Replaces #670.

@tdakkota tdakkota changed the title feat(gen): avoid empty response types feat(gen): avoid empty response types (part 3) Dec 14, 2022
@codecov
Copy link

codecov bot commented Dec 14, 2022

Codecov Report

Base: 74.30% // Head: 74.31% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (af48d1e) compared to base (ad15ce2).
Patch coverage: 88.88% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #724      +/-   ##
==========================================
+ Coverage   74.30%   74.31%   +0.01%     
==========================================
  Files         176      176              
  Lines       12721    12748      +27     
==========================================
+ Hits         9452     9474      +22     
- Misses       2786     2789       +3     
- Partials      483      485       +2     
Impacted Files Coverage Δ
gen/ir/operation.go 82.85% <88.88%> (+1.44%) ⬆️
gen/gen_contents.go 74.26% <0.00%> (-0.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ernado ernado merged commit 833671a into ogen-go:main Dec 14, 2022
@tdakkota tdakkota deleted the feat/avoid-empty-response-types branch December 14, 2022 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants