feat(gen): support user-defined JSON Schema formats #728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdakkota
force-pushed
the
feat/custom-formats
branch
from
b8d14b1 to
7abfdd8
Compare
Codecov ReportBase: 74.38% // Head: 74.45% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #728 +/- ##
==========================================
+ Coverage 74.38% 74.45% +0.06%
==========================================
Files 176 179 +3
Lines 12734 12869 +135
==========================================
+ Hits 9472 9581 +109
- Misses 2781 2799 +18
- Partials 481 489 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
tdakkota
force-pushed
the
feat/custom-formats
branch
3 times, most recently
from
ff42575 to
60827ba
Compare
This is a workaround for `goimports`: it does not treat called function as missing package, unlike field lookup of global variable. Otherwise, `goimports` will try to search for the non-existing package and will check every package in the GOPATH/module cache. This leads to a very big slowdown.
tdakkota
force-pushed
the
feat/custom-formats
branch
from
60827ba to
21dcffd
Compare
ernado
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.