Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): allow to define custom format for primitive types #730

Merged
merged 5 commits into from
Dec 22, 2022

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Dec 22, 2022

Codecov Report

Base: 74.46% // Head: 74.39% // Decreases project coverage by -0.06% ⚠️

Coverage data is based on head (a896e22) compared to base (f701b6a).
Patch coverage: 64.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #730      +/-   ##
==========================================
- Coverage   74.46%   74.39%   -0.07%     
==========================================
  Files         179      181       +2     
  Lines       12869    12902      +33     
==========================================
+ Hits         9583     9599      +16     
- Misses       2798     2812      +14     
- Partials      488      491       +3     
Impacted Files Coverage Δ
gen/generator.go 57.83% <ø> (-1.55%) ⬇️
gen/ir/custom_format.go 50.00% <0.00%> (-50.00%) ⬇️
...ernal/integration/customformats/phonetype/phone.go 100.00% <ø> (ø)
...nternal/integration/customformats/rgbatype/rgba.go 100.00% <ø> (ø)
gen/schema_gen.go 80.15% <30.00%> (-2.71%) ⬇️
gen/custom_format.go 65.27% <65.27%> (ø)
internal/integration/customformats/hextype/hex.go 100.00% <100.00%> (ø)
gen/gen_contents.go 74.26% <0.00%> (-0.74%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as ready for review December 22, 2022 12:13
@ernado ernado merged commit 040369b into ogen-go:main Dec 22, 2022
@tdakkota tdakkota deleted the feat/custom-format-primitive-types branch December 23, 2022 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants