Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): check security requirements correctly #743

Merged
merged 9 commits into from
Jan 11, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Jan 10, 2023

Codecov Report

Base: 74.03% // Head: 74.42% // Increases project coverage by +0.39% 🎉

Coverage data is based on head (9037229) compared to base (6dd31bc).
Patch coverage: 97.50% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #743      +/-   ##
==========================================
+ Coverage   74.03%   74.42%   +0.39%     
==========================================
  Files         183      184       +1     
  Lines       13070    13110      +40     
==========================================
+ Hits         9676     9757      +81     
+ Misses       2897     2856      -41     
  Partials      497      497              
Impacted Files Coverage Δ
gen/ir/operation.go 82.85% <ø> (ø)
openapi/operation.go 75.00% <ø> (ø)
gen/gen_security.go 81.98% <93.33%> (+13.98%) ⬆️
gen/ir/json.go 82.64% <100.00%> (-0.98%) ⬇️
gen/ir/security.go 81.81% <100.00%> (+6.81%) ⬆️
internal/bitset/bitset.go 100.00% <100.00%> (ø)
openapi/parser/parse_security.go 96.75% <100.00%> (+0.12%) ⬆️
ogenerrors/ogenerrors.go 38.46% <0.00%> (+23.07%) ⬆️
ogenerrors/handler.go 82.14% <0.00%> (+82.14%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as draft January 10, 2023 13:34
@tdakkota tdakkota marked this pull request as ready for review January 11, 2023 08:48
@tdakkota tdakkota force-pushed the fix/security branch 2 times, most recently from 2449ad5 to 4de0254 Compare January 11, 2023 14:32
@ernado ernado merged commit d4b3b4d into ogen-go:main Jan 11, 2023
@tdakkota tdakkota deleted the fix/security branch January 11, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants