Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(uri): return an error if value contains separator char #786

Merged
merged 10 commits into from
Mar 7, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@codecov
Copy link

codecov bot commented Feb 13, 2023

Codecov Report

Patch coverage: 70.41% and project coverage change: -0.15 ⚠️

Comparison is base (ad14554) 74.11% compared to head (b699d39) 73.96%.

❗ Current head b699d39 differs from pull request most recent head 4348a98. Consider uploading reports for the commit 4348a98 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #786      +/-   ##
==========================================
- Coverage   74.11%   73.96%   -0.15%     
==========================================
  Files         189      190       +1     
  Lines       13407    13515     +108     
==========================================
+ Hits         9937     9997      +60     
- Misses       2965     2997      +32     
- Partials      505      521      +16     
Impacted Files Coverage Δ
uri/cookie_encoder.go 68.42% <25.00%> (-13.94%) ⬇️
uri/receiver.go 46.96% <40.00%> (-0.58%) ⬇️
uri/cookie_param_encoder.go 54.05% <44.44%> (-13.95%) ⬇️
uri/header_param_encoder.go 58.06% <44.44%> (-20.89%) ⬇️
uri/query_param_encoder.go 68.04% <71.42%> (-6.96%) ⬇️
uri/path_encoder.go 82.83% <82.35%> (-4.67%) ⬇️
internal/httpcookie/valid.go 100.00% <100.00%> (ø)
openapi/parser/parse_parameter.go 95.00% <100.00%> (+0.09%) ⬆️
uri/header_encoder.go 72.22% <100.00%> (-1.47%) ⬇️
uri/query_encoder.go 77.77% <100.00%> (-0.80%) ⬇️
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the fix/check-path-value branch 2 times, most recently from e1145c1 to c713e5d Compare February 16, 2023 14:02
@tdakkota tdakkota force-pushed the fix/check-path-value branch from c713e5d to e365aa3 Compare February 28, 2023 08:31
@tdakkota tdakkota force-pushed the fix/check-path-value branch from e365aa3 to 9bd05c9 Compare February 28, 2023 16:57
@tdakkota tdakkota force-pushed the fix/check-path-value branch from 3eb6d6f to 074618e Compare March 1, 2023 09:06
@tdakkota tdakkota marked this pull request as ready for review March 7, 2023 11:01
@tdakkota tdakkota force-pushed the fix/check-path-value branch from b699d39 to 4348a98 Compare March 7, 2023 11:01
@ernado ernado merged commit 257d5d5 into ogen-go:main Mar 7, 2023
@tdakkota tdakkota deleted the fix/check-path-value branch March 7, 2023 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants