Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gen): rewrite multipart form generation #872

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

tdakkota
Copy link
Member

Fixes #870

@codecov
Copy link

codecov bot commented Apr 20, 2023

Codecov Report

Patch coverage: 85.71% and project coverage change: +0.04 🎉

Comparison is base (a87baa4) 75.69% compared to head (998d9bd) 75.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
+ Coverage   75.69%   75.73%   +0.04%     
==========================================
  Files         189      189              
  Lines       13806    13821      +15     
==========================================
+ Hits        10450    10468      +18     
+ Misses       2828     2826       -2     
+ Partials      528      527       -1     
Impacted Files Coverage Δ
gen/schema_gen.go 81.02% <25.00%> (-0.62%) ⬇️
gen/tstorage.go 59.80% <57.14%> (+0.39%) ⬆️
gen/gen_schema.go 76.56% <90.00%> (+5.40%) ⬆️
gen/gen_contents.go 73.88% <91.66%> (+0.73%) ⬆️
gen/gen_parameters.go 64.77% <100.00%> (ø)
gen/genctx.go 90.90% <100.00%> (+0.28%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota force-pushed the fix/multipart-forms branch from 11992d4 to 998d9bd Compare April 20, 2023 13:04
@tdakkota tdakkota marked this pull request as ready for review April 20, 2023 13:25
@ernado ernado merged commit 0fe0880 into ogen-go:main Apr 20, 2023
@tdakkota tdakkota deleted the fix/multipart-forms branch April 20, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(gen): referenced formdata type name conflict
2 participants