feat(gen): no NPE on default stream responses #875
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdakkota
requested changes
Apr 24, 2023
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## main #875 +/- ##
=======================================
Coverage 75.75% 75.75%
=======================================
Files 189 189
Lines 13854 13854
=======================================
Hits 10495 10495
Misses 2837 2837
Partials 522 522 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Hi! Please
|
ernado
changed the title
auto-merge was automatically disabled
April 25, 2023 16:54
Head branch was pushed to by a user without write access
natehart
force-pushed
the
stream-template
branch
from
10af458 to
a5bc6e0
Compare
|
I think you need to rebase instead of merge, so merge commit won’t be in your branch 🙃 |
natehart
force-pushed
the
stream-template
branch
from
7fc8f17 to
27589c6
Compare
|
Derp. That's what I get for using GitHub's options... |
natehart
force-pushed
the
stream-template
branch
2 times, most recently
from
20ec958 to
56268c1
Compare
The current implementation of the templated stream response `Read(byte[])` function uses the `Data io.Reader` field without first checking for `nil`. Users who want to return a value with an empty body are forced to explicitly specify an empty `io.Reader` rather than simply ignore the field and get use from the empty struct. This commit adds a `nil` check before using the `Data` field and, if it is `nil`, responds as if it were an empty `io.Reader` instead of panicking. This will hopefully make this library slightly more ergonomic to use.
natehart
force-pushed
the
stream-template
branch
from
56268c1 to
301b6db
Compare
tdakkota
approved these changes
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of the templated stream response
Read(byte[])function uses theData io.Readerfield without first checking fornil.Users who want to return a value with an empty body are forced to explicitly specify an empty
io.Readerrather than simply ignore the field and get use from the empty struct.This commit adds a
nilcheck before using theDatafield and, if it isnil, responds as if it were an emptyio.Readerinstead of panicking.This will hopefully make this library slightly more ergonomic to use.