Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(jsonschema): move default value type check to generator #877

Merged
merged 2 commits into from
Apr 25, 2023

Conversation

tdakkota
Copy link
Member

No description provided.

@tdakkota tdakkota force-pushed the refactor/move-default-typecheck branch from 287cec3 to 78a8ebf Compare April 25, 2023 06:02
@codecov
Copy link

codecov bot commented Apr 25, 2023

Codecov Report

Patch coverage: 61.25% and project coverage change: -0.02 ⚠️

Comparison is base (982b8fc) 75.75% compared to head (78a8ebf) 75.73%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #877      +/-   ##
==========================================
- Coverage   75.75%   75.73%   -0.02%     
==========================================
  Files         189      189              
  Lines       13821    13854      +33     
==========================================
+ Hits        10470    10493      +23     
- Misses       2825     2838      +13     
+ Partials      526      523       -3     
Impacted Files Coverage Δ
jsonschema/parser_enum.go 59.77% <48.27%> (+6.70%) ⬆️
gen/schema_gen.go 79.56% <68.00%> (-1.47%) ⬇️
jsonschema/parser.go 83.69% <100.00%> (-0.96%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ernado ernado merged commit c1ded8d into ogen-go:main Apr 25, 2023
@tdakkota tdakkota deleted the refactor/move-default-typecheck branch April 25, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants