Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(gen): support uniqueItems validator #887

Merged
merged 5 commits into from
May 3, 2023

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented May 2, 2023

Fixes #132

@codecov
Copy link

codecov bot commented May 2, 2023

Codecov Report

Patch coverage: 88.88% and no project coverage change.

Comparison is base (42e3aa6) 72.38% compared to head (ba5b4d8) 72.39%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #887   +/-   ##
=======================================
  Coverage   72.38%   72.39%           
=======================================
  Files         190      190           
  Lines       14491    14514   +23     
=======================================
+ Hits        10490    10508   +18     
- Misses       3478     3481    +3     
- Partials      523      525    +2     
Impacted Files Coverage Δ
gen/schema_gen.go 79.24% <72.72%> (-0.33%) ⬇️
gen/ir/validation.go 76.66% <100.00%> (+0.47%) ⬆️
validate/array.go 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tdakkota tdakkota marked this pull request as ready for review May 3, 2023 05:45
@ernado ernado merged commit cd5350d into ogen-go:main May 3, 2023
@tdakkota tdakkota deleted the feat/unique-items branch May 3, 2023 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

validator, gen: support uniqueItems array validation
2 participants