Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parser): compare canonical parameter name #892

Merged
merged 1 commit into from
May 3, 2023

Conversation

tdakkota
Copy link
Member

@tdakkota tdakkota commented May 3, 2023

No description provided.

@codecov
Copy link

codecov bot commented May 3, 2023

Codecov Report

Patch coverage: 95.00% and project coverage change: +0.04 🎉

Comparison is base (cd5350d) 72.39% compared to head (ee37e95) 72.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #892      +/-   ##
==========================================
+ Coverage   72.39%   72.44%   +0.04%     
==========================================
  Files         190      190              
  Lines       14514    14531      +17     
==========================================
+ Hits        10508    10527      +19     
+ Misses       3481     3480       -1     
+ Partials      525      524       -1     
Impacted Files Coverage Δ
openapi/parser/parse_parameter.go 95.20% <85.71%> (+0.09%) ⬆️
openapi/parser/parse_header.go 100.00% <100.00%> (ø)

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ernado ernado merged commit f0564d2 into ogen-go:main May 3, 2023
@tdakkota tdakkota deleted the fix/compare-canonical-name branch May 3, 2023 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants