Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
adding a
--hyperlink
option like inls
feel free to throw any comments at the code
Edit: it seems like your inline output is broken on master (is fine on latest release),
meaning even if output can be displayed on one-two lines, it will spread as one file per line (try running exa from master on the exa root dir, then try it the same with v0.10.1/ ls)
As far as I've tested, this is because of the upgrade to term_grid 0.2.0
since then,
grid.fit_into_width(self.console_width)
returns None for what would've been validconsole_width
in past versions.I will at least match the behavior of hyperlink to regular exa, so that if/ when you do fix it, it'll work fine with the hyperlink flag aswell
also read my comments, especially on the new escape function
thanks