Merge pull request #20 from opticrd:fix/user-creation-on-iam

fix: user registration on IAM fixed
ogticrd · May 10, 2023 · 1b3ef8e · 1b3ef8e
2 parents b9c3800 + c8d49a5
commit 1b3ef8e
Show file tree

Hide file tree

Showing 3 changed files with 61 additions and 21 deletions.
diff --git a/src/pages/api/biometric/index.ts b/src/pages/api/biometric/index.ts
@@ -45,21 +45,31 @@ export default async function handler(
         responseType: "arraybuffer",
       });
 
-      result = await rekognition.compareFaces({
-        SimilarityThreshold: 80,
-        TargetImage: {
-          Bytes: data,
-        },
-        SourceImage: {
-          Bytes: response.ReferenceImage.Bytes,
-        },
-      });
+      try {
+        result = await rekognition.compareFaces({
+          SimilarityThreshold: 80,
+          TargetImage: {
+            Bytes: data,
+          },
+          SourceImage: {
+            Bytes: response.ReferenceImage.Bytes,
+          },
+        });
+      } catch (ex) {
+        console.log(`Biometry validation failed for citizen ${cedula}`);
+
+        return res.status(500).json({
+          success: false,
+        });
+      }
     }
 
     const { FaceMatches } = result;
     const isFaceMatched =
       FaceMatches && FaceMatches.length && FaceMatches[0].Similarity > 90;
 
+    console.log(`Biometry validation successfully for citizen ${cedula}`);
+
     return res.status(200).json({
       match: isFaceMatched,
     });

diff --git a/src/pages/api/iam/index.ts b/src/pages/api/iam/index.ts
@@ -1,7 +1,10 @@
 import { NextApiRequest, NextApiResponse } from "next/types";
-import axios from "axios";
+import axios, { AxiosError } from "axios";
 
-import { VerifyIamUserResponse } from "../types";
+import {
+  CitizensBasicInformationResponse,
+  VerifyIamUserResponse,
+} from "../types";
 
 export default async function handler(
   req: NextApiRequest,
@@ -26,6 +29,37 @@ export default async function handler(
     return res.status(200).json(data);
   } else if (req.method === "POST") {
     const { body } = req;
-    await http.post(`/auth/signup`, body);
+    const { username, email, password } = body;
+
+    let success: boolean = true;
+    let statusCode: number = 201;
+
+    const { data: citizen } = await axios.get<CitizensBasicInformationResponse>(
+      `${process.env.NEXT_PUBLIC_CEDULA_API}/${username}/info/basic?api-key=${process.env.NEXT_PUBLIC_CEDULA_API_KEY}`
+    );
+
+    try {
+      await http.post(`/auth/signup`, {
+        firstName: citizen.payload.names,
+        lastName: `${citizen.payload.firstSurname} ${citizen.payload.secondSurname}`,
+        username,
+        email,
+        password,
+      });
+
+      console.log(`Citizens ${username} created successfully on IAM`);
+    } catch (ex: unknown) {
+      console.log(`Error ocurred trying to create citizen ${username} on IAM`);
+      success = false;
+
+      if (ex instanceof AxiosError) {
+        const { response } = ex;
+        statusCode = response?.status ? response?.status : 500;
+      } else {
+        statusCode = 500;
+      }
+    }
+
+    return res.status(statusCode).json({ success });
   }
 }
diff --git a/src/pages/register/stepper/step3.tsx b/src/pages/register/stepper/step3.tsx
@@ -66,16 +66,12 @@ export default function Step3({ handleNext, infoCedula }: any) {
   const onSubmit = (data: IFormInputs) => {
     setLoading(true);
 
-    const obj = {
-      email: data.email,
-      username: infoCedula?.payload?.id,
-      firstName: infoCedula?.payload?.names,
-      lastName: `${infoCedula?.payload?.firstSurname} ${infoCedula?.payload?.secondSurname}`,
-      password: data.password,
-    };
-
     axios
-      .post("/api/iam", obj)
+      .post("/api/iam", {
+        email: data.email,
+        username: infoCedula.id,
+        password: data.password,
+      })
       .then(() => {
         handleNext();
       })