fix(verification): display error when the code is invalid

ogticrd · Jul 13, 2024 · b441125 · b441125
1 parent dabc1f4
commit b441125
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 5 deletions.
diff --git a/src/app/[lang]/verification/form.tsx b/src/app/[lang]/verification/form.tsx
@@ -98,7 +98,9 @@ export function Form({ flow, returnTo, code }: Props) {
             case 410:
             // Status code 410 means the request has expired - so let's load a fresh flow!
             case 403:
+            case 404:
               // Status code 403 implies some other issue (e.g. CSRF) - let's reload!
+              setOtp(Array<string>(6).fill(''));
               return router.push('/verification');
           }
 
@@ -134,8 +136,12 @@ export function Form({ flow, returnTo, code }: Props) {
         updateVerificationFlowBody: { method: 'code', code },
       })
       .then(({ data }) => {
-        // Form submission was successful, show the message to the user!
-        setCurrentFlow(data);
+        // Check for errors
+        const errors = data.ui.messages?.filter((msg) => msg.type === 'error');
+
+        if (errors?.length) {
+          throw new Error(errors.at(0)?.text);
+        }
 
         router.push('/account-created');
       })

diff --git a/src/dictionaries/en.json b/src/dictionaries/en.json
@@ -104,7 +104,7 @@
     },
     "code": {
       "badUrl": "The code link is incorrect or has expired.",
-      "wrong": "The code is incorrect"
+      "wrong": "The code is incorrect or has expired."
     },
     "createIdentity": "An error occurred trying to create the citizen account. Please, try again later.",
     "decryption": "Error decrypting:",

diff --git a/src/dictionaries/es.json b/src/dictionaries/es.json
@@ -103,8 +103,8 @@
       "validation": "No podemos validar la seguridad de su navegador, verifique si tiene actualizaciones pendientes o intente con otro dispositivo."
     },
     "code": {
-      "badUrl": "Enlace del código es incorrecto o ha expirado",
-      "wrong": "El código es incorrecto"
+      "badUrl": "Enlace del código es incorrecto o ha expirado.",
+      "wrong": "El código es incorrecto o ha expirado."
     },
     "createIdentity": "Ha ocurrido un error intentando crear la cuenta ciudadana. Por favor, inténtelo más tarde.",
     "decryption": "Error al desencriptar:",