Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#20: Added the implementation to show an image from a url #24

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

#20: Added the implementation to show an image from a url #24

wants to merge 14 commits into from

Conversation

vanlooverenkoen
Copy link

Fixed #20

@vanlooverenkoen
Added the shared now playing implementation
6f15f66
@vanlooverenkoen
oguzhnatly#20: Added the implementation to show an image from a url
39536d0
@vanlooverenkoen
Merge branch 'feature/now-playing' into combined
3ab7e7f
@vanlooverenkoen
oguzhnatly#12: Added support for flutter to start in the background. …
d45954e 
…Even when the app was killed
@vanlooverenkoen
Merge branch 'feature/oguzhnatly#12-carplay-background' into combined
073a45e
@vanlooverenkoen
oguzhnatly#17: Keep the stack history in swift to make sure we can tr…
cd4f28f 
…igger the completion handler as well
@vanlooverenkoen
Merge branch 'bugfix/oguzhnatly#17-completion-handler-not-finished' i…
ee91108 
…nto combined
@vanlooverenkoen
Support for file path
fcf339c
@vanlooverenkoen
Merge branch 'feature/oguzhnatly#20-imageurl' into combine-all
a182231
@vanlooverenkoen
Updated the file implementation
1e1981b
@vanlooverenkoen
Updated the cleanup
7393dcf
@vanlooverenkoen
Merge branch 'feature/oguzhnatly#20-imageurl' into combine-all
77f1763
@vanlooverenkoen
Added support to handle images on the background
3320e70
@vanlooverenkoen
Copy link
Author

First merge the #22 pull request

@vanlooverenkoen
Copy link
Author

First merge the #25 pull request

@vanlooverenkoen
Copy link
Author

First merge the #26 pull request

@vanlooverenkoen vanlooverenkoen mentioned this pull request Oct 18, 2022
Open
@oguzhnatly
Copy link
Owner

Thank you for your contribution @vanlooverenkoen!
I'm testing on real devices and cars as well. Once it's done, I will be approving and merge the changes as soon possible.

@oguzhnatly oguzhnatly added new-feature New feature or request in testing This issue has been testing labels Nov 9, 2022
@vanlooverenkoen vanlooverenkoen mentioned this pull request Nov 14, 2022
Open
maendamedia
maendamedia approved these changes Nov 12, 2023
View reviewed changes
Copy link

@maendamedia maendamedia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maendamedia maendamedia maendamedia approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
in testing This issue has been testing new-feature New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

FCPListItem does not support imageUrl
3 participants
@vanlooverenkoen @oguzhnatly @maendamedia