Handle missing instance.resolved_middleware in asset_updates #2084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ashesh3
requested review from
vigneshhari,
rithviknishad,
khavinshankar and
sainak
khavinshankar
approved these changes
Apr 15, 2024
sainak
approved these changes
Apr 15, 2024
rithviknishad
approved these changes
Apr 15, 2024
vigneshhari
approved these changes
Apr 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2083
This pull request fixes a bug in the asset_updates.py file where the code was not handling the case when the instance.resolved_middleware is None. The fix ensures that the code properly checks for this condition before proceeding.
It returns none when the middleware_hostname is null in all 3 places