Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix attribute error on null values in field serialization #2348

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 8, 2024

Proposed Changes

  • fix attribute error on null values in field serialization

Associated Issue

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner August 8, 2024 13:56
Copy link

sentry-io bot commented Aug 8, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: care/facility/events/handler.py

Function Unhandled Issue
create_consultation_events AttributeError: 'NoneType' object has no attribute '_meta' /api/v1/con...
Event Count: 2

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 63.70%. Comparing base (ee747c6) to head (1e955a5).

Files Patch % Lines
care/utils/event_utils.py 0.00% 13 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2348      +/-   ##
===========================================
- Coverage    63.71%   63.70%   -0.01%     
===========================================
  Files          238      238              
  Lines        13376    13378       +2     
  Branches      1906     1907       +1     
===========================================
  Hits          8522     8522              
- Misses        4504     4506       +2     
  Partials       350      350              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Aug 8, 2024

LGTM

@vigneshhari vigneshhari merged commit 8709830 into develop Aug 8, 2024
9 of 11 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/null-field-serialization branch August 8, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants