Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix consultation create with bed #2375

Merged
merged 1 commit into from
Aug 21, 2024
Merged

Conversation

sainak
Copy link
Member

@sainak sainak commented Aug 21, 2024

Proposed Changes

  • pop the bed before creating consulation

Associated Issue

Architecture changes

  • Remove this section if not used

Merge Checklist

  • Tests added/fixed
  • Update docs in /docs
  • Linting Complete
  • Any other necessary step

Only PR's with test cases included and passing lint and test pipelines will be reviewed

@coronasafe/care-backend-maintainers @coronasafe/care-backend-admins

@sainak sainak requested a review from a team as a code owner August 21, 2024 06:46
Copy link

sentry-io bot commented Aug 21, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: care/facility/api/serializers/patient_consultation.py

Function Unhandled Issue
create TypeError: Got a TypeError when calling PatientConsultation.objects.create(). This may be because you ha... ...
Event Count: 150

Did you find this useful? React with a 👍 or 👎

Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.80%. Comparing base (f3b684f) to head (a0d8563).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2375      +/-   ##
===========================================
+ Coverage    63.77%   63.80%   +0.02%     
===========================================
  Files          239      239              
  Lines        13408    13408              
  Branches      1909     1909              
===========================================
+ Hits          8551     8555       +4     
+ Misses        4508     4505       -3     
+ Partials       349      348       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nihal467
Copy link
Member

nihal467 commented Aug 21, 2024

Test Cases [ In progress ]

  • Create new consultation with all mandatory fields
  • Create new consultation with all optional and mandatory field
  • edit existing consultation
  • generate a discharge summary
  • bed switch in consultation page
  • verify the investigation suggestion is reflected properly

@vigneshhari vigneshhari merged commit 68a3a82 into develop Aug 21, 2024
11 checks passed
@vigneshhari vigneshhari deleted the sainak/fix/consultation-create branch August 21, 2024 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants