Fix Button Overflow and Minor Responsive Issues on Mobile View #10546
Conversation
WalkthroughThis pull request enhances localization support by adding new keys to multiple JSON files and updating several components to utilize these keys through the Changes
Sequence Diagram(s)sequenceDiagram
participant U as User
participant D as UserDashboard
participant T as i18n (useTranslation)
U->>D: Load Dashboard View
D->>T: Call t("welcome_back", {name: user.first_name})
T-->>D: Return translated welcome message
D->>U: Render translated message and updated buttons
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🔇 Additional comments (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
✅ Deploy Preview for care-ohc ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
…damaan/care_feAmaan into issues/10524/minor-responsive
…damaan/care_feAmaan into issues/10524/minor-responsive
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/Questionnaire/QuestionnaireSearch.tsx (1)
96-96: Consider adjusting max-height for better mobile experience.The fixed
max-h-[400px]might be too tall for mobile screens, especially when the keyboard is open. Consider using a responsive max-height:-<div className="max-h-[400px] overflow-y-auto p-0"> +<div className="max-h-[300px] sm:max-h-[400px] overflow-y-auto p-0">
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (4)
public/locale/en.json(4 hunks)src/components/Questionnaire/QuestionnaireSearch.tsx(1 hunks)src/pages/Patients/VerifyPatient.tsx(1 hunks)src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx(2 hunks)
✅ Files skipped from review due to trivial changes (1)
- src/pages/Scheduling/components/CreateScheduleExceptionSheet.tsx
🚧 Files skipped from review as they are similar to previous changes (1)
- public/locale/en.json
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: cypress-run (1)
🔇 Additional comments (2)
src/components/Questionnaire/QuestionnaireSearch.tsx (1)
83-83: Great responsive design implementation!The change from a fixed width to a responsive width using
w-full sm:w-[600px]effectively addresses the mobile view issues while maintaining the desktop experience. This is a solid implementation of mobile-first responsive design.src/pages/Patients/VerifyPatient.tsx (1)
167-167: LGTM! Effective fix for button overflow.Adding
w-fullto the container div ensures proper content alignment and prevents overflow issues on mobile view. The change maintains consistency with the existing responsive design patterns.
…damaan/care_feAmaan into issues/10524/minor-responsive
|
|
Proposed Changes
change 2
change 3
change 4
@ohcnetwork/care-fe-code-reviewers
Merge Checklist
Summary by CodeRabbit
Summary by CodeRabbit