fix: update gender validation to include required error message

[areebahmeddd]

Proposed Changes

• Fixes Gender field validation error when not selected in Edit User modal #10461

Previous PR (#10462) fixed the gender validation error for the patient registration form but missed the user form. This update ensures the required error message is applied consistently.

@ohcnetwork/care-fe-code-reviewers

Summary by CodeRabbit

• Bug Fixes
  • Updated the user form so that if no gender is selected, a clear, custom error message is displayed, helping users understand the required field more effectively.

[coderabbitai]

Walkthrough

The pull request updates the validation schema in the UserForm.tsx component. It modifies the gender field validation by replacing the basic enum validation with one that includes a custom error message (t("gender_is_required")) when no gender is selected. No exported or public declarations were modified.

Changes

File(s)	Change Summary
src/components/Users/UserForm.tsx	Updated the validation schema for the gender field to use z.enum(GENDERS, { required_error: t("gender_is_required") }).

Possibly related PRs

• fix responsiveness of date field and gender in public patient registration form #10294: Enhancements to the gender selection validation in the UI closely relate to these modifications.
• Fixed the cypress failure in users form #10101: This PR introduced a gender property in user creation tests and selection functionality, aligning with the current change.
• Fix: Bugs in Public Patient Registration Form  #10462: Updated gender validation using z.enum with a custom error message connects directly to these changes.

Suggested labels

needs review, changes required

Suggested reviewers

• rithviknishad

Poem

I'm a bunny with a joyful stride,
Hopping through code with a playful guide.
Custom errors now gleam in the form,
Clear messages set; the norm is transformed.
Celebrating changes with a hop and a smile! 🐇

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 7d7cfd6 and 38ad6c4.

📒 Files selected for processing (1)

• src/components/Users/UserForm.tsx (1 hunks)

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: rajku-dev
PR: ohcnetwork/care_fe#9887
File: src/components/Users/CreateUserForm.tsx:93-93
Timestamp: 2025-01-14T09:22:13.878Z
Learning: In CreateUserForm.tsx, the gender validation schema uses string literals that match GENDER_TYPES.map(g => g.id). Using GENDER_TYPES directly with z.enum() fails because it's marked with 'as const' which makes it a readonly tuple type incompatible with Zod's enum.

src/components/Users/UserForm.tsx (3)

Learnt from: rajku-dev
PR: ohcnetwork/care_fe#9887
File: src/components/Users/CreateUserForm.tsx:93-93
Timestamp: 2025-01-14T09:22:13.878Z
Learning: In CreateUserForm.tsx, the gender validation schema uses string literals that match GENDER_TYPES.map(g => g.id). Using GENDER_TYPES directly with z.enum() fails because it's marked with 'as const' which makes it a readonly tuple type incompatible with Zod's enum.

Learnt from: Jacobjeevan
PR: ohcnetwork/care_fe#10027
File: src/components/Users/UserForm.tsx:34-34
Timestamp: 2025-01-17T11:34:37.003Z
Learning: In the care_fe codebase, the GENDERS constant is defined with a type assertion `as [(typeof GENDER_TYPES)[number]["id"]]` which makes it compatible with `z.enum()` in Zod schemas. This pattern is preferred over using string literals directly.

Learnt from: rajku-dev
PR: ohcnetwork/care_fe#9887
File: src/components/Users/CreateUserForm.tsx:93-93
Timestamp: 2025-01-14T09:22:13.878Z
Learning: The suggestion to use GENDER_TYPES.map(g => g.id) for gender enum validation in CreateUserForm.tsx was incorrect and caused an error.

🔇 Additional comments (2)

src/components/Users/UserForm.tsx (2)

94-94: LGTM! Gender validation updated with required error message.

The implementation correctly adds the required error message using the translation function and follows the proper pattern for Zod enum validation.

---

529-561: LGTM! Gender field implementation is well-integrated.

The gender field implementation:

• Uses the Select component with proper accessibility attributes
• Correctly binds to the form control
• Renders gender options from GENDER_TYPES
• Displays validation messages via FormMessage component

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[netlify]

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	38ad6c4
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67ac9e73e9b1cd0008c505f5
😎 Deploy Preview	https://deploy-preview-10577.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[github-actions]

@areebahmeddd Your efforts have helped advance digital healthcare and TeleICU systems. 🚀 Thank you for taking the time out to make CARE better. We hope you continue to innovate and contribute; your impact is immense! 🙌