Improve responsiveness of User Details page #10714

Tanuj1718 · 2025-02-20T09:16:16Z

Proposed Changes

Fixes Facility Users Page needs responsiveness #10686

@ohcnetwork/care-fe-code-reviewers

Merge Checklist

Add specs that demonstrate bug / test a new feature.
Update product documentation.
Ensure that UI text is kept in I18n files.
Prep screenshot or demo video for changelog entry, and attach it to issue.
Request for Peer Reviews
Completion of QA

Summary by CodeRabbit

Style
- Enhanced the visual layout of user information areas with improved alignment and consistent styling.
- Adjusted text presentation to incorporate better overflow handling and truncation for a cleaner display of user details.
- Updated semantic structure of HTML elements for better accessibility and styling consistency.

…evelop

…x-ui

coderabbitai · 2025-02-20T09:16:26Z

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Walkthrough

The pull request updates the HTML structure and styling of two user-related components. In the UserBanner component, class names are reordered, <h1> tags are replaced with <p> tags (with truncation handling), and the layout shifts from flex to grid. Additionally, the UserStatusIndicator receives an extra padding class. In UserViewDetails, <span> elements in the LabelValue component are replaced with <p> tags (with truncation applied to values), and the Badge component now wraps its text in a <div> instead of a <span>. No changes were made to exported interfaces.

Changes

File(s)	Change Summary
`src/components/Users/UserBanner.tsx`	Reordered class names in the outer `<div>`; replaced `<h1>` with `<p>` for user names with the `truncate` class; updated layout from flex to `grid grid-cols-1`; added `pl-0` to `UserStatusIndicator`; changed final `<span>` to `<p>`.
`src/components/Users/UserViewDetails.tsx`	Replaced `<span>` elements with `<p>` in the `LabelValue` component (adding the `truncate` class to values); changed the `Badge` component wrapper from `<span>` to `<div>`.

Possibly related PRs

Fix Online Status Indicator in Organization Tab #9728: The changes in the main PR related to the UserStatusIndicator component are directly connected to the modifications in the retrieved PR, which also involves the UserStatusIndicator for displaying user online status.

Suggested labels

tested, reviewed

Suggested reviewers

Jacobjeevan
rithviknishad

Poem

I'm a coding bunny, full of glee,
Updating tags from <span> to <p> with ease,
With a hop in the grid and a skip in the flex,
Truncated texts now dance like little specks,
My paws type magic into every line—
CodeRabbit cheers these changes, so fine! 🐰✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

netlify · 2025-02-20T09:17:05Z

✅ Deploy Preview for care-ohc ready!

Name	Link
🔨 Latest commit	`49ef1b6`
🔍 Latest deploy log	https://app.netlify.com/sites/care-ohc/deploys/67b82c4d2342cc0008e38fb0
😎 Deploy Preview	https://deploy-preview-10714.preview.ohc.network
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/components/Users/UserBanner.tsx (1)
28-32: Consider consolidating padding control.

The component has both addPadding prop and a className="pl-0" which might be redundant. Consider consolidating the padding control into a single approach.
                <UserStatusIndicator
                  user={userData}
-                  addPadding
-                  className="pl-0"
+                  className="pl-0 pr-2"  {/* Adjust padding in one place */}
                />

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0d089c3 and de6422a.

📒 Files selected for processing (2)

src/components/Users/UserBanner.tsx (1 hunks)
src/components/Users/UserViewDetails.tsx (2 hunks)

✅ Files skipped from review due to trivial changes (1)

src/components/Users/UserViewDetails.tsx

⏰ Context from checks skipped due to timeout of 90000ms (1)

GitHub Check: cypress-run (1)

🔇 Additional comments (2)

src/components/Users/UserBanner.tsx (2)

15-15: LGTM! Container layout improvements look good.

The container layout changes maintain responsive behavior while ensuring proper width and consistent spacing.

22-22: LGTM! Grid layout enhances content structure.

The switch to grid layout with grid-cols-1 provides better control over content alignment and supports the responsive design goals.

src/components/Users/UserBanner.tsx

Jacobjeevan

Marking as draft, make the changes, test it fully, self-review and mark it as ready for review when done.

src/components/Users/UserViewDetails.tsx

Jacobjeevan · 2025-02-20T14:24:56Z

src/components/Users/UserBanner.tsx

        <div className="flex flex-row gap-2 self-center">
          <Avatar
            imageUrl={userData?.profile_picture_url}
            name={formatDisplayName(userData)}
            className="h-20 w-20 md:mr-2 lg:mr-3 lg:h-16 lg:w-16"
          />
-          <div className="flex flex-col self-center">
+          <div className="grid grid-cols-1 self-center">


You should be able to do this without changing this to grid.

Also test for other devices:

Also add tool tip as well.

is it bad practice to use grid or something else?🤔 Because here we can obtain our desired structure using grids.

Tanuj1718 and others added 27 commits February 4, 2025 00:21

improved tablet view responsiveness

ea4a69b

solved i18n issue

85bfad8

Merge branch 'develop' into develop

09f613a

update mobile view responsiveness

158d709

Merge branch 'develop' into develop

b39654d

added responsiveness in organization users page

c4586e6

Merge branch 'develop' into develop

ea48433

minor change in button

73c1773

Merge branch 'develop' of https://github.com/Tanuj1718/care_fe into d…

5283828

…evelop

draft pr

ffdb6df

modified date-field handlers

f46c2eb

minor cleanup

4dfd361

Merge branch 'develop' into fix-issue

70eca3e

Merge branch 'develop' into fix-issue

6f00675

revert unwanted changes

e1b3c37

fix responsiveness

a32aeef

Merge branch 'develop' into fix-ui

6d12bf1

minor change

ebdc962

Merge remote-tracking branch 'upstream/develop' into fix-ui

ad685aa

Merge branch 'fix-ui' of https://github.com/Tanuj1718/care_fe into fi…

fbe0648

…x-ui

Merge remote-tracking branch 'upstream/develop' into fix-ui

5a4a397

Merge remote-tracking branch 'upstream/develop' into fix-ui

0474c0b

solved type error

ffdbb95

updated with requested changes

4db802e

Merge remote-tracking branch 'upstream/develop' into fix-ui

b366d3e

update ui

b61eec4

updated code

de6422a

Tanuj1718 requested a review from a team as a code owner February 20, 2025 09:16

coderabbitai bot reviewed Feb 20, 2025

View reviewed changes

src/components/Users/UserBanner.tsx Outdated Show resolved Hide resolved

minor updation

ad537e2

Jacobjeevan requested changes Feb 20, 2025

View reviewed changes

Jacobjeevan marked this pull request as draft February 20, 2025 14:25

Jacobjeevan added the changes required label Feb 20, 2025

Tanuj1718 added 2 commits February 21, 2025 12:36

minor changes

7cc0b7e

minor changes

49ef1b6

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve responsiveness of User Details page #10714

Improve responsiveness of User Details page #10714

Tanuj1718 commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

Review skipped

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

netlify bot commented Feb 20, 2025 •

edited

Loading

coderabbitai bot left a comment

Jacobjeevan left a comment

Jacobjeevan Feb 20, 2025 •

edited

Loading

Tanuj1718 Feb 20, 2025

Improve responsiveness of User Details page #10714

Are you sure you want to change the base?

Improve responsiveness of User Details page #10714

Conversation

Tanuj1718 commented Feb 20, 2025 • edited by coderabbitai bot Loading

Proposed Changes

Merge Checklist

Summary by CodeRabbit

coderabbitai bot commented Feb 20, 2025 • edited Loading

Review skipped

Walkthrough

Changes

Possibly related PRs

Suggested labels

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

netlify bot commented Feb 20, 2025 • edited Loading

✅ Deploy Preview for care-ohc ready!

coderabbitai bot left a comment

Choose a reason for hiding this comment

Jacobjeevan left a comment

Choose a reason for hiding this comment

Jacobjeevan Feb 20, 2025 • edited Loading

Choose a reason for hiding this comment

Tanuj1718 Feb 20, 2025

Choose a reason for hiding this comment

Tanuj1718 commented Feb 20, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Feb 20, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

netlify bot commented Feb 20, 2025 •

edited

Loading

Jacobjeevan Feb 20, 2025 •

edited

Loading